Skip to content

Conversation

@foxish
Copy link
Member

@foxish foxish commented Jan 15, 2025

This should fix the cause of why some seconds disappear because we're replacing the number of seconds in the current datetime, rather than adding.

@foxish foxish requested a review from davixcky January 15, 2025 16:35
@davixcky
Copy link
Contributor

@foxish thanks, but i think Arjun want also to remove the countdown. So no need to add this(?

@github-actions
Copy link

Frontend Sandbox Ready!
https://app.signadot.com/sandbox/name/pr-258-frontend

@github-actions
Copy link

Frontend Test Results

2 tests   1 ✅  2s ⏱️
1 suites  1 💤
1 files    0 ❌

Results for commit 5bfa4f6.

@foxish
Copy link
Member Author

foxish commented Jan 16, 2025

@foxish thanks, but i think Arjun want also to remove the countdown. So no need to add this(?

I confirmed we do want to keep the countdown @davixcky - so, PTAL.

@foxish foxish merged commit 7309349 into main Jan 20, 2025
8 checks passed
@foxish foxish deleted the fix-time-bug branch January 20, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants